Permissions

We’re going to write this test with the person not logged in and redirect, but it’ll take another test to get the Authenticator into the production code.

import { fake, AbstractSpruceFixtureTest } from '@sprucelabs/spruce-test-fixtures'

//@fake.login() will ensure a fake person is logged in for each test
@fake.login()
export default class RootSkillViewTest extends AbstractSpruceFixtureTest {

    @test()
    protected static async redirectsToOnboardingIfNotLoggedIn() {
        const vc = this.views.Controller('eightbitstories.root', {})

        //first thing we do is log the person back out =)
        this.permissions.getAuthenticator().clearSession()

        //Assert that loading the skill view redirects
        await vcAssert.assertActionRedirects({
            action: () => this.views.load(vc),
            router: this.views.getRouter(),
            destination: {
                id: 'eightbitstories.onboarding',
            },
        })
    }
}

We actually don’t need to check if the person is logged in yet! Go TDD!

import { AbstractSkillViewController, SkillViewControllerLoadOptions } from '@sprucelabs/heartwood-view-controllers'

export default class RootSkillViewController extends AbstractSkillViewController {

    public async load(
        options: SkillViewControllerLoadOptions
    ): Promise<void> {
        const { router } = options

        await this.router.redirect('eightbitstories.onboarding')
        
    }
}

Now we’ll test that it does NOT redirect if someone is logged in, which will force us to do the authenticator.isLoggedIn() check. Something to note: If a redirect is triggered without an assert, it will throw an error and fail the test. So, you don’t actually need to assert anything in this test.

...

@test()
protected static async shouldNotRedirectIfLoggedIn() {
    const vc = this.views.Controller('eightbitstories.root', {})

    //Because we use the @fake.login() decorator, the person is already logged in
    await this.views.load(vc)
}

...

import { AbstractSkillViewController, SkillViewControllerLoadOptions } from '@sprucelabs/heartwood-view-controllers'

export default class RootSkillViewController extends AbstractSkillViewController {

    public async load(
        options: SkillViewControllerLoadOptions
    ): Promise<void> {
        const { router, authenticator } = options

        if (!authenticator.isLoggedIn()) {
            await this.router.redirect('eightbitstories.onboarding')
        }
    }
}

Here is how you could refactor your tests to make them more readable and maintainable.

import { fake, AbstractSpruceFixtureTest } from '@sprucelabs/spruce-test-fixtures'
import RootSkillViewController from '../../skillViewControllers/Root.svc'

@fake.login()
export default class RootSkillViewTest extends AbstractSpruceFixtureTest {
    protected static vc: RootSkillViewController

    protected static async beforeEach() {
        await super.beforeEach()

        //Construct the RootSkillViewController once here to work on in every test
        this.vc = this.views.Controller('eightbitstories.root', {})
    }

    @test()
    protected static async redirectsToOnboardingIfNotLoggedIn() {
        //This could be exctracted too, but I'll wait until the second time we need to call it
        this.permissions.getAuthenticator().clearSession()

        await vcAssert.assertActionRedirects({
            action: () => this.load(),
            router: this.views.getRouter(),
            destination: {
                id: 'eightbitstories.onboarding',
            },
        })
    }

    @test()
    protected static async shouldNotRedirectIfLoggedIn() {
        await this.load()
    }

    //I'll extract `this.views.load(this.vc)` to `this.load()` because it's been called twice now
    protected static async load() {
        await this.views.load(this.vc)
    }
}